SONARJAVA-4960 False positive for S1854 #5378
Conversation
rombirli
force-pushed
the
rombirli/S1854-false-positive
branch
from
19d09dc to
947f918
Compare
|
This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically |
| } | ||
|
|
||
| @Test | ||
| void test_fp() { |
There was a problem hiding this comment.
Test name should be more precise.
There was a problem hiding this comment.
I proposed test_incomplete_semantic as a more precise name in my last commit
...-checks-test-sources/default/src/main/files/non-compiling/checks/UnusedVariablesFPCheck.java
Show resolved
Hide resolved
...-checks-test-sources/default/src/main/files/non-compiling/checks/UnusedVariablesFPCheck.java
Outdated
Show resolved
Hide resolved
| assertThat(unknownSymbol.isPackageSymbol()).isFalse(); | ||
| assertThat(unknownSymbol.isTypeSymbol()).isFalse(); | ||
| assertThat(unknownSymbol.isVariableSymbol()).isFalse(); | ||
| assertThat(unknownSymbol.isMethodSymbol()).isFalse(); |
There was a problem hiding this comment.
I didn't read this carefully, but I'm wondering why this is removed instead of reverting the condition.
There was a problem hiding this comment.
Edit :
this line 174 is inside of function private static void assertCommonProperties(Symbol unknownSymbol) which is used by all kinds of unknown symbols tests (unknown_type_symbol, unknown_method_symbol, ...), the isMethodSymbol function is no longer final in the parent abstact class UnknownSymbol , the result can be overriden differently in each child class (UnkownTypeSymbol, UnknownMethodSymbol).
|
2 participants
Uh oh!
There was an error while loading. Please reload this page.